Re: [nft PATCH] Review switch statements for unmarked fall through cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> While revisiting all of them, clear a few oddities as well:
> 
> - There's no point in marking empty fall through cases: They are easy to
>   spot and a common concept when using switch().

NACK, sorry.  There a source-code checkers that flag this
(they have heuristics to detect such comments).

I agree with the rest and would apply the patch w.o. the first hunk,
no need to resend.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux