On Fri, Dec 8, 2017 at 3:15 AM, Florian Westphal <fw@xxxxxxxxx> wrote: > --- /dev/null > +++ b/include/net/netfilter/nf_conntrack_count.h > @@ -0,0 +1,17 @@ > +#ifdef _NF_CONNTRACK_COUNT_H ^^^^^^^^ #ifndef? Looks like a typo in v4. > diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c > index a6214f235333..d69e2f41aaa6 100644 > --- a/net/netfilter/xt_connlimit.c > +++ b/net/netfilter/xt_connlimit.c > static void connlimit_mt_destroy(const struct xt_mtdtor_param *par) > { > const struct xt_connlimit_info *info = par->matchinfo; > - unsigned int i; > > nf_ct_netns_put(par->net, par->family); I run into some issues when load and unload xt_connlimit a couple of times. It turns out that we do nf_ct_netns_put() twice, where the other one is in nf_conncount_destroy(). Maybe get rid of this line? Thanks, -Yi-Hung -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html