On Fri, Dec 08, 2017 at 10:28:28PM +0100, Pablo Neira Ayuso wrote: > On Fri, Dec 08, 2017 at 05:01:54PM +0100, Florian Westphal wrote: [...] > > diff --git a/net/ipv4/netfilter/iptable_nat.c b/net/ipv4/netfilter/iptable_nat.c > > index a1a07b338ccf..0f7255cc65ee 100644 > > --- a/net/ipv4/netfilter/iptable_nat.c > > +++ b/net/ipv4/netfilter/iptable_nat.c > > @@ -72,6 +72,7 @@ static const struct nf_hook_ops nf_nat_ipv4_ops[] = { > > { > > .hook = iptable_nat_ipv4_in, > > .pf = NFPROTO_IPV4, > > + .nat_hook = true, > > Just a suggestion: This nat_hook basically means that we only allow > this hook to be a singleton in this spot. So I would call it like > this, ie. singleton, given we have no NAT semantics in the netfilter > core. Hm, never mind about names. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html