Davide Caratti <dcaratti@xxxxxxxxxx> wrote: > Small nit: may I suggest you to call skb_csum_hwoffload_help() instead of > skb_checksum_help(), so that we avoid corrupting SCTP packets in case they > hit xt_CHECKSUM target? Alternatively we could restrict the target to udp only. AFAIU the only reason this thing exists is to fix up udp checksum for old dhcp clients that use AF_PACKET without evaluating the extra metadata that indicates when a 'bad' checksum is in fact ok because it is supposed to be filled in by hardware later. This can happen in virtual environemnt when such skb is directly passed to vm. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
