Michal Kubecek <mkubecek@xxxxxxx> wrote: > When --checksum_fill action is applied to a GSO packet, checksum_tg() calls > skb_checksum_help() which is only meant to be applied to non-GSO packets so > that it issues a warning. > > This can be easily triggered by using e.g. > > iptables -t mangle -A OUTPUT -j CHECKSUM --checksum-fill > > and sending TCP stream via a device with GSO enabled. > > While this can be considered a misconfiguration, I believe the bad offload > warning is supposed to catch bugs in drivers and networking stack, not > misconfigured firewalls. So let's ignore such packets and only issue a one > time warning with pr_warn_once() rather than a WARN with stack trace and > tainted kernel. Why issue a warning at all? What kind of action should be taken upon seeing such warning? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
