Hide this structure from the user, this allows simplify the simple
functions by just providing easy and meaningfull arguments.
Signed-off-by: Eric Leblond <eric@xxxxxxxxx>
---
include/cli.h | 2 +-
include/nftables.h | 13 +++++++------
include/nftables/nftables.h | 5 ++---
src/cli.c | 10 ++++++++--
src/libnftables.c | 19 +++++++++++--------
src/main.c | 11 +++--------
6 files changed, 32 insertions(+), 28 deletions(-)
diff --git a/include/cli.h b/include/cli.h
index e577400..899c8a6 100644
--- a/include/cli.h
+++ b/include/cli.h
@@ -6,7 +6,7 @@
struct parser_state;
#ifdef HAVE_LIBREADLINE
extern int cli_init(struct nft_ctx *nft, struct mnl_socket *nf_sock,
- struct nft_cache *cache, struct parser_state *state);
+ struct parser_state *state);
#else
static inline int cli_init(struct nft_ctx *nft, struct mnl_socket *nf_sock,
struct nft_cache *cache, struct parser_state *state)
diff --git a/include/nftables.h b/include/nftables.h
index aad204e..348fbb0 100644
--- a/include/nftables.h
+++ b/include/nftables.h
@@ -32,18 +32,19 @@ struct output_ctx {
unsigned int echo;
};
-struct nft_ctx {
- struct output_ctx output;
- bool check;
- struct mnl_socket *nf_sock;
-};
-
struct nft_cache {
bool initialized;
struct list_head list;
uint32_t seqnum;
};
+struct nft_ctx {
+ struct output_ctx output;
+ bool check;
+ struct mnl_socket *nf_sock;
+ struct nft_cache cache;
+};
+
extern unsigned int max_errors;
extern unsigned int debug_level;
extern const char *include_paths[INCLUDE_PATHS_MAX];
diff --git a/include/nftables/nftables.h b/include/nftables/nftables.h
index 20a062c..b902cbd 100644
--- a/include/nftables/nftables.h
+++ b/include/nftables/nftables.h
@@ -27,9 +27,8 @@ void nft_global_deinit(void);
struct nft_ctx *nft_context_new(void);
void nft_context_free(struct nft_ctx *nft);
-int nft_run_command_from_buffer(struct nft_ctx *nft, struct nft_cache *cache,
+int nft_run_command_from_buffer(struct nft_ctx *nft,
char *buf, size_t buflen);
-int nft_run_command_from_filename(struct nft_ctx *nft, struct nft_cache *cache,
- const char *filename);
+int nft_run_command_from_filename(struct nft_ctx *nft, const char *filename);
#endif
diff --git a/src/cli.c b/src/cli.c
index 7501b29..fd5c7b7 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -177,13 +177,17 @@ void __fmtstring(1, 0) cli_display(const char *fmt, va_list ap)
}
int cli_init(struct nft_ctx *nft, struct mnl_socket *nf_sock,
- struct nft_cache *cache, struct parser_state *_state)
+ struct parser_state *_state)
{
const char *home;
+ struct nft_cache cache;
+
+ memset(&cache, 0, sizeof(cache));
+ init_list_head(&cache.list);
cli_nf_sock = nf_sock;
cli_nft = *nft;
- cli_cache = cache;
+ cli_cache = &cache;
rl_readline_name = "nft";
rl_instream = stdin;
rl_outstream = stdout;
@@ -204,6 +208,8 @@ int cli_init(struct nft_ctx *nft, struct mnl_socket *nf_sock,
while (!eof)
rl_callback_read_char();
+
+ cache_release(&cache);
return 0;
}
diff --git a/src/libnftables.c b/src/libnftables.c
index 6d4aceb..864156c 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -63,7 +63,10 @@ struct nft_ctx *nft_context_new(void)
ctx = malloc(sizeof(struct nft_ctx));
if (ctx == NULL)
return NULL;
+
+ memset(ctx, 0, sizeof(*ctx));
ctx->nf_sock = netlink_open_sock();
+ init_list_head(&ctx->cache.list);
return ctx;
}
@@ -74,6 +77,7 @@ void nft_context_free(struct nft_ctx *nft)
if (nft == NULL)
return;
netlink_close_sock(nft->nf_sock);
+ cache_release(&nft->cache);
xfree(nft);
}
@@ -82,7 +86,7 @@ static const struct input_descriptor indesc_cmdline = {
.name = "<cmdline>",
};
-int nft_run_command_from_buffer(struct nft_ctx *nft, struct nft_cache *cache,
+int nft_run_command_from_buffer(struct nft_ctx *nft,
char *buf, size_t buflen)
{
int rc = NFT_EXIT_SUCCESS;
@@ -90,11 +94,11 @@ int nft_run_command_from_buffer(struct nft_ctx *nft, struct nft_cache *cache,
LIST_HEAD(msgs);
void *scanner;
- parser_init(nft->nf_sock, cache, &state, &msgs);
+ parser_init(nft->nf_sock, &nft->cache, &state, &msgs);
scanner = scanner_init(&state);
scanner_push_buffer(scanner, &indesc_cmdline, buf);
- if (nft_run(nft, nft->nf_sock, cache, scanner, &state, &msgs) != 0)
+ if (nft_run(nft, nft->nf_sock, &nft->cache, scanner, &state, &msgs) != 0)
rc = NFT_EXIT_FAILURE;
scanner_destroy(scanner);
@@ -102,22 +106,21 @@ int nft_run_command_from_buffer(struct nft_ctx *nft, struct nft_cache *cache,
return rc;
}
-int nft_run_command_from_filename(struct nft_ctx *nft, struct nft_cache *cache,
- const char *filename)
+int nft_run_command_from_filename(struct nft_ctx *nft, const char *filename)
{
int rc = NFT_EXIT_SUCCESS;
struct parser_state state;
LIST_HEAD(msgs);
void *scanner;
- rc = cache_update(nft->nf_sock, cache, CMD_INVALID, &msgs);
+ rc = cache_update(nft->nf_sock, &nft->cache, CMD_INVALID, &msgs);
if (rc < 0)
return rc;
- parser_init(nft->nf_sock, cache, &state, &msgs);
+ parser_init(nft->nf_sock, &nft->cache, &state, &msgs);
scanner = scanner_init(&state);
if (scanner_read_file(scanner, filename, &internal_location) < 0)
return NFT_EXIT_FAILURE;
- if (nft_run(nft, nft->nf_sock, cache, scanner, &state, &msgs) != 0)
+ if (nft_run(nft, nft->nf_sock, &nft->cache, scanner, &state, &msgs) != 0)
rc = NFT_EXIT_FAILURE;
scanner_destroy(scanner);
diff --git a/src/main.c b/src/main.c
index 20fea87..64b8c58 100644
--- a/src/main.c
+++ b/src/main.c
@@ -184,7 +184,6 @@ static const struct {
int main(int argc, char * const *argv)
{
struct parser_state state;
- struct nft_cache cache;
LIST_HEAD(msgs);
char *buf = NULL, *filename = NULL;
unsigned int len;
@@ -192,9 +191,6 @@ int main(int argc, char * const *argv)
int i, val, rc = NFT_EXIT_SUCCESS;
struct nft_ctx *nft;
- memset(&cache, 0, sizeof(cache));
- init_list_head(&cache.list);
-
nft_global_init();
nft = nft_context_new();
while (1) {
@@ -293,17 +289,17 @@ int main(int argc, char * const *argv)
strcat(buf, " ");
}
strcat(buf, "\n");
- rc = nft_run_command_from_buffer(nft, &cache, buf, len + 2);
+ rc = nft_run_command_from_buffer(nft, buf, len + 2);
if (rc < 0)
return rc;
goto out;
} else if (filename != NULL) {
- rc = nft_run_command_from_filename(nft, &cache, filename);
+ rc = nft_run_command_from_filename(nft, filename);
if (rc < 0)
return rc;
goto out;
} else if (interactive) {
- if (cli_init(nft, nft->nf_sock, &cache, &state) < 0) {
+ if (cli_init(nft, nft->nf_sock, &state) < 0) {
fprintf(stderr, "%s: interactive CLI not supported in this build\n",
argv[0]);
exit(NFT_EXIT_FAILURE);
@@ -316,7 +312,6 @@ int main(int argc, char * const *argv)
out:
xfree(buf);
- cache_release(&cache);
iface_cache_release();
nft_context_free(nft);
nft_global_deinit();
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
