Hi Florian, > -----Original Message----- > From: Florian Westphal [mailto:fw@xxxxxxxxx] > Sent: Wednesday, April 5, 2017 9:17 PM > To: gfree.wind@xxxxxxxxxxx > Cc: pablo@xxxxxxxxxxxxx; netfilter-devel@xxxxxxxxxxxxxxx; Gao Feng > <fgao@xxxxxxxxxx> > Subject: Re: [PATCH nf-next 1/1] netfilter: Remove useless variable timeouts in > init_conntrack > > gfree.wind@xxxxxxxxxxx <gfree.wind@xxxxxxxxxxx> wrote: > > From: Gao Feng <fgao@xxxxxxxxxx> > > > > All l4_proto->new callbacks don't use the param timeouts currently, so > > remove it from param list. Then the variable timeouts isn't used as > > right value in init_conntrack, so remove it too. > > Signed-off-by: Gao Feng <fgao@xxxxxxxxxx> > > --- > > include/net/netfilter/nf_conntrack_l4proto.h | 2 +- > > net/ipv4/netfilter/nf_conntrack_proto_icmp.c | 2 +- > > net/netfilter/nf_conntrack_core.c | 13 ++----------- > > net/netfilter/nf_conntrack_proto_dccp.c | 2 +- > > net/netfilter/nf_conntrack_proto_sctp.c | 2 +- > > net/netfilter/nf_conntrack_proto_tcp.c | 2 +- > > net/netfilter/nf_conntrack_proto_udp.c | 2 +- > > 7 files changed, 8 insertions(+), 17 deletions(-) > > What about net/netfilter/nf_conntrack_proto_gre.c ? It's my fault. I only checked the protos in nf_conntrack_ipv4.h. Best Regards Feng -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
