Re: [PATCH nf-next 1/1] netfilter: Remove useless variable timeouts in init_conntrack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gao,

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/gfree-wind-foxmail-com/netfilter-Remove-useless-variable-timeouts-in-init_conntrack/20170406-031517
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_proto_generic.c:196:2: warning: initialization from incompatible pointer type
     .new   = generic_new,
     ^
   net/netfilter/nf_conntrack_proto_generic.c:196:2: warning: (near initialization for 'nf_conntrack_l4proto_generic.new')
--
>> net/netfilter/nf_conntrack_proto_gre.c:374:2: warning: initialization from incompatible pointer type
     .new   = gre_new,
     ^
   net/netfilter/nf_conntrack_proto_gre.c:374:2: warning: (near initialization for 'nf_conntrack_l4proto_gre4.new')
--
>> net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c:377:2: warning: initialization from incompatible pointer type
     .new   = icmpv6_new,
     ^
   net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c:377:2: warning: (near initialization for 'nf_conntrack_l4proto_icmpv6.new')

vim +196 net/netfilter/nf_conntrack_proto_generic.c

22ac03772 Gao feng          2012-06-21  180  
08911475d Pablo Neira Ayuso 2012-06-29  181  static struct nf_proto_net *generic_get_net_proto(struct net *net)
08911475d Pablo Neira Ayuso 2012-06-29  182  {
08911475d Pablo Neira Ayuso 2012-06-29  183  	return &net->ct.nf_ct_proto.generic.pn;
08911475d Pablo Neira Ayuso 2012-06-29  184  }
08911475d Pablo Neira Ayuso 2012-06-29  185  
61075af51 Patrick McHardy   2007-07-14  186  struct nf_conntrack_l4proto nf_conntrack_l4proto_generic __read_mostly =
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  187  {
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  188  	.l3proto		= PF_UNSPEC,
fe2a7ce4d Christoph Paasch  2009-02-18  189  	.l4proto		= 255,
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  190  	.name			= "unknown",
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  191  	.pkt_to_tuple		= generic_pkt_to_tuple,
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  192  	.invert_tuple		= generic_invert_tuple,
9fb9cbb10 Yasuyuki Kozakai  2005-11-09  193  	.print_tuple		= generic_print_tuple,
2c8503f55 Pablo Neira Ayuso 2012-02-28  194  	.packet			= generic_packet,
2c8503f55 Pablo Neira Ayuso 2012-02-28  195  	.get_timeouts		= generic_get_timeouts,
2c8503f55 Pablo Neira Ayuso 2012-02-28 @196  	.new			= generic_new,
509784623 Pablo Neira Ayuso 2012-02-28  197  #if IS_ENABLED(CONFIG_NF_CT_NETLINK_TIMEOUT)
509784623 Pablo Neira Ayuso 2012-02-28  198  	.ctnl_timeout		= {
509784623 Pablo Neira Ayuso 2012-02-28  199  		.nlattr_to_obj	= generic_timeout_nlattr_to_obj,
509784623 Pablo Neira Ayuso 2012-02-28  200  		.obj_to_nlattr	= generic_timeout_obj_to_nlattr,
509784623 Pablo Neira Ayuso 2012-02-28  201  		.nlattr_max	= CTA_TIMEOUT_GENERIC_MAX,
509784623 Pablo Neira Ayuso 2012-02-28  202  		.obj_size	= sizeof(unsigned int),
509784623 Pablo Neira Ayuso 2012-02-28  203  		.nla_policy	= generic_timeout_nla_policy,
509784623 Pablo Neira Ayuso 2012-02-28  204  	},

:::::: The code at line 196 was first introduced by commit
:::::: 2c8503f55fbdfbeff4164f133df804cf4d316290 netfilter: nf_conntrack: pass timeout array to l4->new and l4->packet

:::::: TO: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
:::::: CC: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux