Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 28 Mar 2017, Josh Hunt wrote:

> > Thinking over it I understand better your approach: replace 
> > IPSET_ATTR_NETMASK with IPSET_ATTR_NETMASK_MASK completely and keeping 
> > the former for backward compatibility reasons only. What I propose is 
> > able to maintain syntax-compatibility in the sense that what is passed 
> > to the kernel as cidr/netmask can be saved from there in the same 
> > syntax.
> 
> I have not gone through all of your comments yet, but my intention was 
> to make sure that if cidrs are used they are presented the same way they 
> are today (prior to my patches.) If a user uses the new full netmask 
> support then that is what is shown. This way we stay consistent with 
> whatever the user inputs at create time.

Yes, you are right, some conversion confused me.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux