Re: [PATCH 2/4] netfilter: ipset: generalize netmask to support cidr and mask values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Josh,

On Tue, 28 Mar 2017, Josh Hunt wrote:

> > Overall, I like the feature and the patches. After reviewing I comment
> > only the parts where I believe some modifications are needed.
> 
> Thanks for the review. I'll go through this and send a v2 in the next 
> few days.

Thinking over it I understand better your approach: replace 
IPSET_ATTR_NETMASK with IPSET_ATTR_NETMASK_MASK completely and keeping the 
former for backward compatibility reasons only. What I propose is able to 
maintain syntax-compatibility in the sense that what is passed to the 
kernel as cidr/netmask can be saved from there in the same syntax.

The exemption from adding multiple entries from a range in the case of 
non-cidr value netmask must also be documented in the manpage. Maybe it'd 
be even better additionally to return an explicit error in such cases: 
thus it cannot lead to a misunderstanding from user point of view.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux