From: Gao Feng <fgao@xxxxxxxxxx> There are some netfilter functions which return the literal 1 and 0 as the bool value. We should use bool instead of them. And even though some calleris treat the return value as Neftiler action. For example, the caller would compare the return value with NF_ACCEPT. Luckily the value of NF_ACCEPT is 1, so there is no any real issue. Gao Feng (4): netfilter: amanda: Correct the return value comparison of the func nf_nat_mangle_udp_packet netfilter: irc: Correct the return value comparison of the func nf_nat_mangle_tcp_packet netfilter: helper: Use the bool instead of int type netfilter: sip: Use NF_DROP and NF_ACCEPT instead of 0 and 1 include/net/netfilter/nf_nat_helper.h | 36 +++++++++++++++---------------- net/netfilter/nf_nat_amanda.c | 11 +++++----- net/netfilter/nf_nat_helper.c | 40 +++++++++++++++++------------------ net/netfilter/nf_nat_irc.c | 9 ++++---- net/netfilter/nf_nat_sip.c | 6 +++--- 5 files changed, 50 insertions(+), 52 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html