Hi David, 2017-03-16 18:58 GMT+08:00 David Laight <David.Laight@xxxxxxxxxx>: [...] >> For the similar reason, when loading an u16 value from the u32 data >> register, we should use "*(u16 *) sreg;" instead of "(u16)*sreg;", >> the 2nd method will get the wrong value in the big-endian system. > ... > > That seems to be papering over some of the obvious cracks. > > The fact that the entire 32bits are zeroed makes me suspect that > in some places values are written as 8 bits and read later as 32. > The only way that can work on BE is if the values are always written > as 32 bit ones (assignment style 2). In nftables, user can use concatenations to put two or more selectors together. For example, we can use "nft add rule x y tcp dport . ip saddr 22 . 1.1.1.1" to match the tcp dest port and ip source addr at the same time. In such case, tcp dport will be stored to REG0 and ip saddr will be stored to REG1, so the layout will be like this(from the lowest address): PORT(2 bytes) - XXXX(2 bytes) - IPADDR(4 bytes) Later we will use the statement "memcmp(®, &data, 8)" to do compare, so the XXXX part must be filled with zero to avoid garbage value. > > OTOH using memcmp(,,2) relies on the data being in the lower addressed > bytes. > > If the data does need to be in the lower addressed bytes I'd suggest > using a union rather than all the casts. > > David > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
