Re: [PATCH nf] netfilter: nat: remove incorrect debug assert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 03, 2017 at 01:44:04PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > > However, changing test to if (iph->frag_off) return -NF_ACCEPT seems
> > > wrong too because we have enough info to track. OTOH, this only happens
> > > with HDRINCL+raw socket so perhaps we shouldn't care about this and
> > > just change ipv4 l3 tracker to ignore all packets w. iph->frag_off set.
> > 
> > Florian, unless you rise your hand, I'm going to take this patch so we
> > at least fix splats here. I still have the impression that this
> > setsockopt() option and its interaction with netfilter is broken at
> > many levels.
> 
> Hmmm, I think we should disable tracking of all fragmented packets,
> or at least disable NAT of all fragmented packets.
> 
> If we NAT 1st packet only then frag reasm won't complete anyway.

Right. Would you give a shoot at this? If you do, I'd appreciate.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux