Re: [PATCH nf] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 22, 2016 at 10:36:22AM +0800, Feng Gao wrote:
> Hi Pablo,
> 
> On Wed, Sep 14, 2016 at 5:51 PM, Feng Gao <gfree.wind@xxxxxxxxx> wrote:
> >
> >
> > On Tue, Sep 13, 2016 at 1:17 AM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> > wrote:
> >>
> >> On Fri, Sep 09, 2016 at 11:06:51PM +0800, Feng Gao wrote:
> >> > How about this patch ?
> >>
> >> Is this a theoretical problem? I would really prefer if you do your
> >> work to collect traces that show that the actual sequence adjustment
> >> is not correct.
> >>
> >> > I think it should be one bug of seqadjust.
> >>
> >> "I think this is a bug" is not sufficient, I expect you prove this is
> >> not correct.
> >
> >
> > Yes. Now I only analyze it by codes, and it should check ack flag in theory.
> > Because TCP REST could not contain ack.
> >
> > But I will set up one environment and generate the packet trace.
> >
> > Regards
> > Feng
> >
> 
> I have gotten the packet trace which shows seqadj adjusts the 0 ack
> value, and sent the v3 patch which contains the reproduce steps,
> packet trace, and logs.

Nice, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux