Arturo Borrero Gonzalez <arturo.borrero.glez@xxxxxxxxx> wrote:
> On 31 May 2016 at 17:50, Arturo Borrero Gonzalez
> <arturo.borrero.glez@xxxxxxxxx> wrote:
> > On 31 May 2016 at 16:44, Florian Westphal <fw@xxxxxxxxx> wrote:
> >> I think its better to use a
> >>
> >> } else if (priv->invert) {
> >> return;
> >> }
> >>
>
> Not that easy, we should consider 4 cases:
> * lookup false, invert false -> NFT_BREAK
> * lookup false, invert true -> return w/o NFT_BREAK
> * lookup true, invert false -> return w/o NFT_BREAK
> * lookup true, invert true -> NFT_BREAK
Right...
> The XOR approach in my original patch seems to over these cases, ie,
> we enter the return branch only if lookup&invert are different.
> I think the nft_data_copy() should not worry us if we prevent the
> combination from happening in _init()
Agree, thanks Arturo!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
