On Thu, Apr 14, 2016 at 12:05:27PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > On Tue, Apr 12, 2016 at 06:14:26PM +0200, Florian Westphal wrote:
> > > diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
> > > index 25998fa..4ec1cea 100644
> > > --- a/net/netfilter/nft_ct.c
> > > +++ b/net/netfilter/nft_ct.c
> > > @@ -29,6 +29,11 @@ struct nft_ct {
> > > enum nft_registers dreg:8;
> > > enum nft_registers sreg:8;
> > > };
> > > + union {
> > > + u8 set_bit;
> > > + } imm;
BTW, do you really need this set_bit? I think we can just take the
data from the nft_data structure.
> > > + unsigned int imm_len:8;
This length, you will not need anymore with select_ops(), right=
> > > + struct nft_data immediate;
> >
> > Could you use select_ops() so we don't increase the size of nft_ct for
> > other users?
>
> Sure.
>
> I'd split this into nft_ct (sreg/dreg)
> and nft_ct_set_imm (set from immediate).
I'd suggest "struct nft_ct_reg" and "struct nft_ct_imm", so we can
reuse the immediate from the get part if we can get rid of the imm_len
and set_bit fields.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
