On Tue, Mar 08, 2016 at 02:47:13PM +0100, Jan Engelhardt wrote: > > On Tuesday 2016-03-08 14:37, Pablo Neira Ayuso wrote: > >>>> Those are the userspace bits for the old ip_queue support that was > >>>> removed years ago, since NFQUEUE superseded for many years. > >>>> You can still cd iptables/libipq and type 'make' to compile the > >>>> this small userspace library since we have to keep new iptables > >>>> releases running with old kernels. > >>> > >>> This is always compiling libipq even with --disable-libipq, this looks > >>> like a bug in our build infrastructure. > > If you manually and intentionally chdir to libipq and attempt to built it, why > forbid it? Having "if ENABLE_LIBIPQ" in the toplevel Makefile.am seems > sufficient. That top level "if ENABLE_LIBIPQ" seems fine, I overlooked this. > AS_HELP_STRING([--enable-libipq], [Build and install libipq]) > in configure.ac is also right, since ipq is build-disabled by default. > > >> Yes. Also, I see that devel should have --disable-devel instead of > >> --enable-devel option and the appropriate functionality associated > >> with it. Please correct me if I am wrong here. > > The help texts: > AS_HELP_STRING([--enable-devel], [Install Xtables development headers]) > should indeed read > AS_HELP_STRING([--disable-devel], [Avoid installation of Xtables development headers]) > because headers are build-*enabled* by default. > > But the actual option parsing (--enable-devel, --enable-devel=no, > --disable-devel) that AC_ARG_ENABLE provides needs no change AFAICS. Right, this is also controled via top level Makefile.am. @Shivani, please focus on improving connlabel integration into our configure thing. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
