Re: [PATCH nft 3/4] meta: add probability matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt <jengelh@xxxxxxx> wrote:
> >> >+		if (tmp >= UINT_MAX || d > 0.9999999)
> >> >+			return error(loc, "Probability " META_PROB_FMT " too %s", d, "big");
> >> 
> >> You are misappropriating some 430 points here. 0.9999999 maps to
> >> just 0xfffffe51.
> >
> >Sorry, I am not following.
> 
> 0.9999999997 is still a valid probability, but you are making it 
> impossible to select it by cutting off at d > 0.9999999000.

I'll change it to allow one more digit, so that supported range will
be 0.00000001 (0x0000002a) to
   0.99999999 (0xffffffd4).

(I'll wait a bit in case anyone has opinion where to suppress display of
 LTE op and where to handle de-scaling of the kernel side integer back
 to 0.12345 output).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux