Re: [PATCH nft 3/4] meta: add probability matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 2016-03-03 21:32, Florian Westphal wrote:

>Jan Engelhardt <jengelh@xxxxxxx> wrote:
>> On Thursday 2016-03-03 18:56, Florian Westphal wrote:
>> 
>> >The float value has to be in range of 0.0000001 to 0.9999999 and
>> >+
>> >+		if (tmp >= UINT_MAX || d > 0.9999999)
>> >+			return error(loc, "Probability " META_PROB_FMT " too %s", d, "big");
>> 
>> You are misappropriating some 430 points here. 0.9999999 maps to
>> just 0xfffffe51.
>
>Sorry, I am not following.

0.9999999997 is still a valid probability, but you are making it 
impossible to select it by cutting off at d > 0.9999999000.


>What would you likew to change here?

Change to
	if (tmp >= UINT_MAX || d >= 1)

(or better yet, d > 1)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux