Re: [PATCH net] netfilter: xt_TCPMSS: handle CHECKSUM_COMPLETE in tcpmss_tg6()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Fri, 15 Jan 2016 09:18:44 -0800

> On Fri, 2016-01-15 at 08:43 -0800, Tom Herbert wrote:
> 
>> Probably should have a utility function do this. Maybe something like
>> update_hdr_field(skb, old, new)? Could return new value so above could
>> just be:
>> 
>> ipv6h->payload_len = update_hdr_field(skb, ipv6h->payload_len,
>> htons(ntohs(oldlen) + ret);
> 
> Well, oldlen would still need to be ipv6h->payload_len
> 
> Not sure a helper will be nice for a stable submission.
> 
> Probably better for net-next ?

Agreed.  We already have those csum_replace{2,4}() helpers in net/checksum.h
which we could augment with ones that can handle length changes too.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux