On Fri, Jan 15, 2016 at 9:18 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > On Fri, 2016-01-15 at 08:43 -0800, Tom Herbert wrote: > >> Probably should have a utility function do this. Maybe something like >> update_hdr_field(skb, old, new)? Could return new value so above could >> just be: >> >> ipv6h->payload_len = update_hdr_field(skb, ipv6h->payload_len, >> htons(ntohs(oldlen) + ret); > > Well, oldlen would still need to be ipv6h->payload_len > That comes from the second argument. > Not sure a helper will be nice for a stable submission. > > Probably better for net-next ? > I think this would apply to ipv6: update skb->csum when CE mark is propagated also, maybe others? Seems safer to implement the logic only in one place if possible... No big deal though. > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
