Re: [PATCH nf-next 1/3] netfilter: nfnetlink_queue: remove duplicated obsolete commands handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry for being late often.

On Sun, Nov 08, 2015 at 11:14:54PM +0100, Pablo Neira Ayuso wrote:
> commit 0360ae412d09bc6f4864c801effcb20bfd84520e
> Author: Florian Westphal <fw@xxxxxxxxx>
> Date:   Fri Nov 23 06:22:21 2012 +0000
> 
>     netfilter: kill support for per-af queue backends
> 
> The former behaviour before Florian's patch is that
> NFQNL_CFG_CMD_PF_BIND and NFQNL_CFG_CMD_PF_UNBIND are terminal.
> 
> This code is there not to break backward compatibility, ie. old
> userspace that rely on these commands.
> 
> After this patch, we inspect if there is an existing queue for this,
> which was not happening before.

I tried to follow your advice, would you see again?

> As I said, my concerns go in the direction of possible breakage of old
> code, we shouldn't break backward.

I'm worry about appended patches 3/5 and 5/5 may not follow it.
After these patches applied, userspace can not update instance's
options with invalid command. is it acceptable?

Thanks,

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux