On Mon, Oct 05, 2015 at 11:50:46AM +0900, Ken-ichirou MATSUZAWA wrote:
> This patch enables to include the conntrack information together
> with the packet that is sent to user-space via NFLOG, then a
> user-space program can acquire NATed information by this NFULA_CT
> attribute.
WARNING: suspect code indent for conditional statements (8, 24)
#99: FILE: net/netfilter/nfnetlink_log.c:581:
+ if (ct && nfnl_ct->build(inst->skb, ct, ctinfo,
[...]
+ goto nla_put_failure;
Please, make sure you use tabs next time.
ERROR: trailing whitespace
#102: FILE: net/netfilter/nfnetlink_log.c:584:
ERROR: trailing whitespace
#137: FILE: net/netfilter/nfnetlink_log.c:693:
Please, run checkpatch.pl on your patches next time to address
whitespace errors and wrong indent.
And regarding this:
...
rcu_dereference(nfnl_ct_hook) == NULL) {
it should be:
rcu_access_pointer(nfnl_ct_hook) == NULL) {
I have fixed these issues here this time, no need to resend.
But, would you please resubmit this:
http://patchwork.ozlabs.org/patch/516185/
but using rcu_access_pointer() instead?
BTW, another thing that would be good to investigate is to autoload
nf_conntrack_netlink if the process passes the _F_CONNTRACK flag is
set. Would you have a look into that?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
