Re: [PATCH nft 1/2] src: add dscp support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.11, Pablo Neira Ayuso wrote:
> On Wed, Nov 25, 2015 at 08:01:25PM +0000, Patrick McHardy wrote:
> > On 25.11, Pablo Neira Ayuso wrote:
> > >  #define TYPE_MAX		(__TYPE_MAX - 1)
> > > diff --git a/include/proto.h b/include/proto.h
> > > index a43bf98..41af0c1 100644
> > > --- a/include/proto.h
> > > +++ b/include/proto.h
> > > @@ -176,7 +176,7 @@ enum ip_hdr_fields {
> > >  	IPHDR_INVALID,
> > >  	IPHDR_VERSION,
> > >  	IPHDR_HDRLENGTH,
> > > -	IPHDR_TOS,
> > > +	IPHDR_DSCP,
> > 
> > Shouldn't we keep both? I think it should work to do that or at least not be
> > difficult to make it work.
> 
> Last time we discussed this, people arised concerns related to the
> fact that this is obsolete, and nobody should be using this these
> days.

I don't really buy into these arguments. We support lots of obsolete things,
the fact is that even though it is obsoleted, it still exists and for old
devices might even be the only thing they support.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux