On Monday 2015-10-19 00:50, Jan Engelhardt wrote:
>On Saturday 2015-10-17 12:57, Pablo Neira Ayuso wrote:
>>Something like this (that we already have in nftables) should be fine:
>>
>> AC_ARG_ENABLE([debug],
>>- AS_HELP_STRING([--enable-debug], [Enable debugging]),
>>- [with_debug=no],
>>+ AS_HELP_STRING([--enable-debug], [Disable debugging]),
>>+ AS_IF([test "x$enable_debug" = "xno"], [with_debug=no],
>>[with_debug=yes]),
>> [with_debug=yes])
>
>Well the whole AS_IF part is not really needed, because you
>are already testing in AM_CONDITIONAL:
That is to say, I find that something like the following would be
quite sufficient.
commit d0e677da000b1034df13718d4388ca78fbea97e6
Author: Jan Engelhardt <jengelh@xxxxxxx>
Date: Mon Oct 19 01:59:33 2015 +0200
build: simplify parsing of --enable-debug
diff --git a/configure.ac b/configure.ac
index 0d7e6ed..780a3e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -24,10 +24,8 @@ AC_DEFINE([_STDC_FORMAT_MACROS], [], [printf-style format macros])
AC_ARG_ENABLE([debug],
AS_HELP_STRING([--enable-debug], [Disable debugging]),
- AS_IF([test "x$enable_debug" = "xno"], [with_debug=no], [with_debug=yes]),
- [with_debug=yes])
-AC_SUBST(with_debug)
-AM_CONDITIONAL([BUILD_DEBUG], [test "x$with_debug" != xno])
+ [enable_debug="$enableval"], [enable_debug=yes])
+AM_CONDITIONAL([BUILD_DEBUG], [test "x$enable_debug" != xno])
# Checks for programs.
AC_PROG_CC
@@ -135,5 +133,5 @@ AC_OUTPUT
echo "
nft configuration:
cli support: ${with_cli}
- enable debugging: ${with_debug}
+ enable debugging: ${enable_debug}
use mini-gmp: ${with_mini_gmp}"
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
