On Friday 2015-10-16 21:23, Arturo Borrero Gonzalez wrote: >On 16 October 2015 at 16:10, Jan Engelhardt <jengelh@xxxxxxx> wrote: >> >> On Friday 2015-10-16 14:10, Arturo Borrero Gonzalez wrote: >> >>>+AC_ARG_ENABLE([systemd], >>>+ AS_HELP_STRING([--disable-systemd], [Do not build systemd support]), >>>+ [enable_systemd="no"], [enable_systemd="yes"]) >> >> This is incorrect. It needs to be >> >> [enable_systemd="$enableval"], [enable_systemd="yes"]) >> > >I don't understand why. Could you please elaborate? The code above >(cthelper, cttimeout) is also bad? > >https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Package-Options.html Quoting the page: — Macro: AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not-given]) If the user gave configure the option --enable-feature or --disable-feature, run shell commands action-if-given. So $ ./configure --enable-systemd runs the 3rd argument, and always sets enable_systemd=no, which is counter to what the user requested of configure. In that regard, yes, conntrack-tools is also negatively affected. Possibly other software from netfilter.org too. >Sending READY=1 is just a basic starting feature. I don't want to >implement more things until it's clear we want systemd integration in >conntrackd. ok -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
