On Thu, Oct 15, 2015 at 01:53:11PM -0700, Eric Dumazet wrote: > On Thu, 2015-10-15 at 23:20 +0300, Nikolay Borisov wrote: > > > While GFP_ATOMIC does indeed look the correct solution for this particular > > case I was wondering whether something like (GFP_KERNEL & ~__GFP_WAIT) > > wouldn't also make the cut without causing sleeping? I guess this is exactly > > the sort of situation that Mel Gorman's patch can address > > (marc.info/?l=linux-kernel&m=144283282101953) ? > > This is not applicable here, because the caller would have to find a way > to keep trying. > > I believe one way to handle this problem (in a followup patch) would be > to use a work queue for the gc, not a timer. > > Using a timer for gc is almost always subject to big problems anyway. Agreed, this is what we're doing in nft_hash. Thanks for feedback Eric! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
