On Thu, Oct 15, 2015 at 9:46 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote: > >> Nikolay answered this pretty well: we wouldn't need the spinlock at all, >> because all commands are serialized anyway with the netlink mutex. But the >> garbage collector is called by a timer and therefore spinlock is used. >> > > Good, please Nikolay, send a v2 of the patch with all these details > explained in the changelog, so that we can all agree. While GFP_ATOMIC does indeed look the correct solution for this particular case I was wondering whether something like (GFP_KERNEL & ~__GFP_WAIT) wouldn't also make the cut without causing sleeping? I guess this is exactly the sort of situation that Mel Gorman's patch can address (marc.info/?l=linux-kernel&m=144283282101953) ? In any case I will send v2 tomorrow. > > If properly explained, no need to add the stack trace which does not > really tell us the story. > > Thanks ! > > > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
