On Mon, Oct 12, 2015 at 05:26:30PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Sep 11, 2015 at 12:15:35PM +0900, Ken-ichirou MATSUZAWA wrote:
> > -#include <linux/netfilter/nfnetlink_log.h>
> > +/* #include <linux/netfilter/nfnetlink_log.h> */
>
> Do you remember why you had to comment out this line?
I think I intended to use linux_nfnetlink_log.h synched previous
and made this mistake.
> > + switch (ntohl(mnl_attr_get_u32(attr))) {
> > + case IP_CT_ESTABLISHED:
> > + s = "IP_CT_ESTABLISHED";
>
> For this example, you can probably simplify this with.
>
> case IP_CT_ESTABLISHED:
> case IP_CT_ESTABLISHED_REPLY:
> s = "ESTABLISHED";
[...]
> IP_CT_IS_REPLY is never used alone, it's is always combined with NEW,
> ESTABLISHED, RELATED states.
[...]
> IP_CT_NUMBER should never happen. Please remove this code.
I try to fix aboves and would you review the following again?
Thanks,
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
