On Wed, Sep 09, 2015 at 06:50:42PM +0900, Ken-ichirou MATSUZAWA wrote: > Hi Pablo, > > Thank you for taking your time. > > On Tue, Sep 08, 2015 at 06:54:48PM +0200, Pablo Neira Ayuso wrote: > > They are totally untested, so please carefully review them. > > I'm sorry I could not to meet your expectations since I might not > understand your intention correctly, please let me ask three > questions: > > * We will not modularize nfqueue attaching conntrack information > part? (was nfnetlink_queue_ct.c) After my patchset, everything is in nf_conntrack_netlink.c, so you only need some little extra glue code to access the nfnl_ct indirection from nfnetlink_log.c > * May I update nfqnl_ct prefix to nfnl_ct after this patch series > applied to attach nfct info to nflog? Yes, that's the idea. > * We do not add another Kconfig for nflog attaching ct info? I think you can add it too, yes. > I tested your patch a little with following lnf-queue patch and > it works fine. Thanks for reporting. So will you send a follow up patchset on top of those three to add what you need? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
