On Wed, Sep 09, 2015 at 06:55:16PM +0900, Ken-ichirou MATSUZAWA wrote: > On Tue, Sep 08, 2015 at 06:54:51PM +0200, Pablo Neira Ayuso wrote: > [...] > > rename from net/netfilter/nfnetlink_queue_core.c > > rename to net/netfilter/nfnetlink_queue.c > > So you know though, we can delete the nfnetlink_queue_core.o line > from Makefile. Right, the Makefile update is missing. I'm going to fix that here. > May I suggest one thing? How about returning -EOPNOTSUPP at > nfqnl_recv_config() if derefering nfq_ct_hook is NULL? Makes sense. Thus, the user knows that it is not supported, please send a patch for that. BTW, I think it would be good to add the missing code on nfqnl_recv_verdict_batch() to support conntrack there too. Would you add that code for nfnetlink_queue.c? Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html