Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 07 Apr 2015 20:56:40 +0200

> This idea would imply to e.g. rename nf_hook_state into something not
> associated with netfilter. Otherwise I don't see any dependencies on
> netfilter.
> 
> I like the patches as-is and if not necessary we don't need to do this.

It's going to be NULL if netfilter didn't run because we only instantiate
the on-stack state when it's actually needed and we're going to call
down into netfilter.

Instantiating it unconditionally is not an option, because unless
netfilter runs setting up that structure is a complete waste of work.

Then we have strange semantics where this state thing is NULL,
depending upon whether netfilter was invoked or not.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux