From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 07 Apr 2015 16:44:29 +0200
> On So, 2015-04-05 at 22:19 -0400, David Miller wrote:
>> --- a/include/linux/netfilter.h
>> +++ b/include/linux/netfilter.h
>> @@ -54,7 +54,7 @@ struct nf_hook_state {
>> struct net_device *in;
>> struct net_device *out;
>> struct sock *sk;
>> - int (*okfn)(struct sk_buff *);
>> + int (*okfn)(struct sock *, struct sk_buff *);
>> };
>
> If we give okfn the signature int (*okfn)(struct nf_hook_state *); then
> we would not need to touch anything else to enhance this.
>
> What do you think?
We do not want nf_hook_state being an argument for non-netfilter output
functions in the various protocols.
So this is a terrible idea.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
