Re: [PATCH lnf-ct 0/2] add mark event filter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2015 at 07:18:26AM +0900, Ken-ichirou MATSUZAWA wrote:
>  Hi,
> 
> This patchset adds mark filter for event listener and its test.
> Would you review?

Looks fine.

It would be good if someone can send follow up patches to:

1) Replace hardcoded '127' values by constants.

2) Assert on too many address/mark/etc instead of silently ignoring.
   The existing behaviour doesn't look good to me as the user will not
   know that it has reach the limit. Unfortunately this function was not
   designed at that time to return an error instead, so we cannot change
   that :-(
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux