On 03/12/2015 07:35 PM, Florian Westphal wrote: > Florian Westphal <fw@xxxxxxxxx> wrote: >>>> + BUILD_BUG_ON(sizeof(struct nf_bridge_skb_cb) > FIELD_SIZEOF(struct sk_buff, cb)); >>>> + >>> >>> Please use sock_skb_cb_check_size(size) for cb size checking which is the >>> 'new' check for cb sizes for netdev. >> >> I can do this for conistency, but its technically not needed here. > > I take that back, it would actually be inconsistent to use > sock_skb_cb_check_size since nf_bridge skbs will not be associated with > sockets. > Ok. I just wanted to make sure that the use of the cb[]-space doesn't clash with the new space that's acquired by the dropcount stuff. Sorry for the noise :-) Best regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
