Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
> On 03/12/2015 06:05 PM, Florian Westphal wrote:
> > nf_bridge_info->mask is used for several things, for example to remember
> > if skb->pkt_type was set to OTHER_HOST.
> >
> > For a bridge, OTHER_HOST is expected case. For ip forward its a
> > non-starter though -- routing expects PACKET_HOST.
> >
> > Bridge netfilter thus changes OTHER_HOST to PACKET_HOST
> > before hook invocation and then un-does it after hook traversal.
> >
> > For this, cb[] can be used since the skb will never be used outside
> > (fake inet) bridge forwarding while in 'fake PACKET_HOST' state.
> >
> > Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> > ---
> > include/linux/netfilter_bridge.h | 1 -
> > net/bridge/br_netfilter.c | 71 ++++++++++++++++++++++++++--------------
>
>
> > @@ -1104,6 +1125,8 @@ static int __init br_netfilter_init(void)
> > {
> > int ret;
> >
> > + BUILD_BUG_ON(sizeof(struct nf_bridge_skb_cb) > FIELD_SIZEOF(struct sk_buff, cb));
> > +
>
> Please use sock_skb_cb_check_size(size) for cb size checking which is the
> 'new' check for cb sizes for netdev.
I can do this for conistency, but its technically not needed here.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
