-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/17/2015 10:54 PM, Pablo Neira Ayuso wrote: > On Tue, Feb 17, 2015 at 10:35:40PM +0100, Jozsef Kadlecsik wrote: >> On Tue, 17 Feb 2015, Pablo Neira Ayuso wrote: >> >>> On Tue, Feb 17, 2015 at 10:35:35AM -0500, Eric B Munson wrote: >>>> It would be useful for userspace to query the size of an >>>> ipset. This data is held for both the bitmask and hash >>>> types, however, it is not exposed to userspace. This patch >>>> uses the otherwise unused attribute IPSET_ATTR_ELEMENTS to >>>> indicate the size in the the header that is exported to >>>> userspace. >>> >>> Thanks for your patch. >>> >>> I think Jozsef will need the userspace bits for his library >>> and utility. >> >> Yes, that's missing from the patch. Also, I don't like any change >> which affects the userspace but not expressed in new set type >> revision. Later on the new revision makes much simpler to >> identify why the "Elements: is missing from the listing of a >> set. > > Please address Jozsef's feedback and resubmit. Thanks. > The missing user space was my mistake, I sent an early version of the patch. The correct version is in flight. Eric -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJU5O3DAAoJELbVsDOpoOa9hF4QALAGxVYC6Tvt3TNH8TQZk9aK dS9rwP/6GL+pj5eUzpDlPRzvfuTqWcg2OVOGsOSYsrlzVfBwveSg++EsXq6fm5CU RmtgnbrBRK9exIDmpD89loDBgWANvMajGfIGVdWlC7gblOoPzZrMJByeUfOrw1WB sJm6lodWnqfQJFGDdXGl0ZFX0C71Hvt5y7NF9vBQhXF0U9smooyvNT+tng1Y8faU 9jLbscOxwKtlLRYtpRMpQ+kg4YmWbu3mdR3UqGvlCb3KYK3C79XfJPTdYur9zc5s RNyrIXkXye31LCOgmZ7YYxcALUb2MRdsHU05dbPuq1/0RRFGaSjNNKJkBX798aTk snzHYmqo7ldySB5uvLqdcr6MtQi0KkTGmdhPZAbWFm26SFx3e3tywdDzFUweT95R /39t9uee++vAfB8wa9W+tGZ2zddkK90GYTKFb4flF0bTS7Bv4POVYKW2c9siX4eG HKQuWx66L1SSRfih1u3MMle5yv+C/2uud255rz5PcqbqXbZ3d71o2+tRmf9TqZW1 yHu6rbJbIHu/e+bLSM6yjVdiRAC4zjokT2LzvCsWRasdIb2Rw3raND/2M6L81ZpH u+Iz5hLXKZJ7nC0M8iTqIWAOpas+9IDjV/AwM4LW1erNgJ5qXX35bwWHIhMdViDt ModRCpWkBlLTq+stLZpQ =6nGr -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
