Re: [PATCH RESEND] Add element count to bitmap and hash headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 17, 2015 at 10:35:40PM +0100, Jozsef Kadlecsik wrote:
> On Tue, 17 Feb 2015, Pablo Neira Ayuso wrote:
> 
> > On Tue, Feb 17, 2015 at 10:35:35AM -0500, Eric B Munson wrote:
> > > It would be useful for userspace to query the size of an ipset.  This
> > > data is held for both the bitmask and hash types, however, it is not
> > > exposed to userspace.  This patch uses the otherwise unused attribute
> > > IPSET_ATTR_ELEMENTS to indicate the size in the the header that is
> > > exported to userspace.
> > 
> > Thanks for your patch.
> > 
> > I think Jozsef will need the userspace bits for his library and
> > utility.
> 
> Yes, that's missing from the patch. Also, I don't like any change which 
> affects the userspace but not expressed in new set type revision. Later on 
> the new revision makes much simpler to identify why the "Elements: is 
> missing from the listing of a set.

Please address Jozsef's feedback and resubmit. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux