On Mon, Jan 26, 2015 at 02:36:13PM -0800, David Miller wrote: > > I really think the amount of time and effort being put into making > the walker function properly is excessive. > > Let's just say that if you want to use rhashtable, you have to use a > linked list, or similar separate mechanism, to have stable walks of > the entire set of objects. I definitely agree with that :) However, I'd really like to get these primitives in first so that at least I can convert the existing rhashtable walkers over and get on with implementing rhashtable rehashing which is what I set out to do. As otherwise we'd be looking at fixing the existing users (in particular, nft_hash) properly which might take a lot more time. If and when we finally fix the existing users we can always remove these primitives. FWIW when I first wrote this patch I called it rhashtable_walk_dangerously, I can readopt that name if you think that will dissuade people from using it. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
