Re: [PATCH v3] netfilter: conntrack: remove timer from ecache extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> This patch looks good to me. I made some experiments again in my
> testbed. I see no packet drops and the result of 'conntrack -L dying |
> wc -l' per second shows small peaks of entries waiting in the dying
> list to be delivered which is followed by empty lists by conntrackd at
> some point.

Thanks a lot for all the testing Pablo.

> However, perhaps the per-second watch is not enough to get
> a real evolution on how the dying list population evolves along time.

Yes, you might be right.
IFF you think its useful, we could add a counter to keep track of the
maximum length of entries that the ecache worker has seen and
export that via ctnetlink (like we do for number of conntracks, search
list restarts, etc etc).

> Anyway, I think this is good enough to get rid of the extra timer. We
> can enqueue this patch to 3.17, unless you have any objection.

No objections from me, thanks Pablo!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux