Re: [PATCH v3] netfilter: conntrack: remove timer from ecache extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian,

Thanks for this new round.

On Tue, Jun 10, 2014 at 11:12:56PM +0200, Florian Westphal wrote:
> This brings the (per-conntrack) ecache extension back to 24 bytes in size
> (was 152 byte on x86_64 with lockdep on).
> 
> When event delivery fails, re-delivery is attempted via work queue.
> 
> Redelivery is attempted at least every 0.1 seconds, but can happen
> more frequently if userspace is not congested.
> 
> The nf_ct_release_dying_list() function is removed.
> With this patch, ownership of the to-be-redelivered conntracks
> (on-dying-list-with-DYING-bit not yet set) is with the work queue,
> which will release the references once event is out.

I think we need to keep the nf_ct_release_dying_list(), otherwise we
will hit problems when destroying the kmem_cache, since the workqueue
may race with that, right?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux