Hello, Sorry for the delay in the review. On Wed, 2014-03-26 at 21:11 +0900, Ken-ichirou MATSUZAWA wrote: > Hello Eric. > > Thank you for taking your time to see it and your reply. > > > Some generic points regarding this patchset: > > I'm resending all with following it, sorry for your inconvenience > And you wrote... > > > Subject: Re: [PATCH 1/8] ipfix: use nfct_bitmask > > available on the system. As it is possible to build ulogd with > > --disable-nfct configure flags, you need to make the build of IPFIX I've just realized this means you won't be able to build IPFIX module if you don't have a new version of libnetfilter_conntrack. I don't want to dump once again the required version of the libs. So you should add a check on nfct_bitmask in the configure.ac to be sure you will be able to build IPFIX. > I see. I should have seen input/Makefile.am before, thank you. > > > Subject: Re: [PATCH 5/8] ipfix: add function for ipfix message creation > > I don't like this malloc because ulogd will do an allocation for each > > I think we can fix allocation sizes for each of template and I worked > at PATCH 8/8 but you could not see it because the patches format were > invalid, sorry. I'm basically ok with the patchset if we omit the nfct_bitmask issue. I've just fixed two remaining whitespace issues and I can provide you the updated patchset if you want. BR, -- Eric Leblond <eric@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
