Hello,
On Sat, 2014-03-08 at 10:03 +0900, Ken-ichirou MATSUZAWA wrote:
> Hello,
>
> If there is someone who is working on ulogd_output_IPFIX, please let me
> know. I need it and would work on it.
Thanks lot for working on it.
> This patch series make progress, not work completely, just print IPFIX
> packet format. Would you review this? I think this has four issues.
>
> * Install nfct_bitmask in libnetfilter_conntrack
> This needs libnetfilter_conntrack patch I'll send after.
Not an issue because Florian did accept your patch.
> * Send only one dataset, not multiple at once
> And it (will) send a message each time when output_ipfix() is called.
> It's not efficient sending.
I don't think there is possibly issue with starting with that
implementation and then provide a better one later.
> * No options template and data
> Do we need these scope data?
> 4. Specific Reporting Requiremt in RFC7011, says MAY be implemented
IPFIX is in ulogd wanted feature list since so long that this is not an
issue if we don't implement the extended feature. The only point is to
be able to interact cleanly with IPFIX collector in the market.
> * Template retransmit timing
> It send template per messages specified in config file.
> I took a glance softflowd and follow that.
Good idea to mimic an existing software.
Some generic points regarding this patchset:
* There is some whitespace errors please fix them when resending
* I need the Signed-off-by line in your patch (for the same reason
as in Linux
https://www.kernel.org/doc/Documentation/SubmittingPatches)
More comments to come in reply to individual patches.
BR,
--
Eric Leblond <eric@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
