On Fri, 2014-03-07 at 17:15 +0100, Florian Westphal wrote: > Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > > I would call tree_nodes_free() _before_ attempting the > > kmem_cache_alloc(), so that the allocation can reuse a hot object that > > you freed right before allocation. > > Hmm, that would be nice. I need to think about it again, > problem is that moving it at this time could result in > freeing the would-be parent of the new node. Yeah, thats why fq_gc() is followed by a full lookup. In practice, the lookup done in fq_gc() brings in cpu cache all the cache lines, and second lookup is very fast. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
