On Wed, Feb 05, 2014 at 10:25:48AM +0000, Patrick McHardy wrote: > Just noticed commit cc70d069 (netfilter: REJECT: separate reusable code). > That doesn't look like a good idea to me at all. > > First of all, it introduces static non-inline functions into a header file, > which is obviously wrong. But more importantly, it adds a symbol dependency > of the reject module on IPv6. We've tried hard to get rid of all these in > x_tables, lets please not re-add them in nftables. Well, I think this is working at this moment, we can improve it of course. > I think we should instead use AF-specific modules for things like that. > We share basically no code except the boiler plate. I'd suggest to add > an AF-specific expression type lookup mechanism that takes precedence > over generic types. Yes, this looks like the way to go to me. How do you plan to handle this with the inet table? We don't have family context there. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
