> > I chose to not just extend the first RCU protected area but putting > > the rcu_read_unlock() down, because there is a 'return' in between. > > I'd suggest to do that since your patch still doesn't cover the > direct_rtp nf_nat_sdp_port_hook dereference. Actually with your patch > we have unbalanced RCU locking since the direct_rtp case contains > a "goto err1". Sure, I'll send a 2nd patch in a new thread. /Holger -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html