On Tue, 30 Apr 2013, David Laight wrote: > > +++ b/net/netfilter/ipset/ip_set_bitmap_gen.h > > @@ -0,0 +1,265 @@ > ... > > +#define CONCAT(a, b) a##b > > +#define TOKEN(a,b) CONCAT(a, b) > > + > > +#define mtype_do_test TOKEN(MTYPE, _do_test) > > +#define mtype_gc_test TOKEN(MTYPE, _gc_test) > ... > > +#define mtype MTYPE > > I'm not entirely sure what is being achieved by the above. > Either there ought to be a comment about what MTYPE might > be set to, or it is all pointless. mtype is defined in order to SHOUT less in the code later. > In any case names like CONCAT() and TOKEN() are likely > to be double definitions. > > A similar namespace issue arises with REVISION_MIN/MAX. I'll send a patch with more speficic names. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
