RE: [PATCH 04/18] netfilter: ipset: Unified bitmap type generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +++ b/net/netfilter/ipset/ip_set_bitmap_gen.h
> @@ -0,0 +1,265 @@
...
> +#define CONCAT(a, b)		a##b
> +#define TOKEN(a,b)		CONCAT(a, b)
> +
> +#define mtype_do_test		TOKEN(MTYPE, _do_test)
> +#define mtype_gc_test		TOKEN(MTYPE, _gc_test)
...
> +#define mtype			MTYPE

I'm not entirely sure what is being achieved by the above.
Either there ought to be a comment about what MTYPE might
be set to, or it is all pointless.

In any case names like CONCAT() and TOKEN() are likely
to be double definitions.

A similar namespace issue arises with REVISION_MIN/MAX.

	David



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux