Re: [PATCH] nfacct: correct regressions in v1.0.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




-static int _nfacct_cmd_add(char *name, int pkts, int bytes)
+static int _nfacct_cmd_add(char *name,
+			   long long unsigned pkts, long long unsigned bytes)

those are still signed, should be unsigned.
Noted.

-		ret = sscanf(buffer, "{ pkts = %lu, bytes = %lu } = %s",
+		ret = sscanf(buffer, "{ pkts = %llu, bytes = %llu } = %s",

Better use %"PRIu64" given that we're using uint64_t.
You learn something new every day. If this is indeed the case, then another patch coming up in a minute.

I have applied a patch based on yours.
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux