Re: [nf-next:nf_tables-experiments PATCH 3/4] nf_tables: Add support for IPv6 NAT expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

  #include <linux/netfilter_ipv4.h>
>@@ -26,8 +27,10 @@
>  #include <net/ip.h>
> > struct nft_nat {
>-	enum nft_registers      sreg_addr_min:8;
>-	enum nft_registers      sreg_addr_max:8;
>+	enum nft_registers      sreg_addr_min_v4:8;
>+	enum nft_registers      sreg_addr_max_v4:8;
>+	enum nft_registers      sreg_addr_min_v6:8;
>+	enum nft_registers      sreg_addr_max_v6:8;
Suggestion: Couldn't we get this patch a bit smaller by adding int
family and the NFTA_NAT_FAMILY attribute?

Why not, at least semantically it could look better indeed, though from struct size point of view it won't change anything.
The logic for parsing NFTA would be easier too.

Let's do this.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux